https://bugzilla.redhat.com/show_bug.cgi?id=977208 --- Comment #26 from Roman Mohr <roman@xxxxxxxxxxxx> --- > > The official github tag is not commit b72745 used by us. I am quite sure > > that you are using an old archive. Please place the correct source tar.gz in > > your SOURCES folder. > > Well, actually, we're using a tag now: v1.2.0. Also, I am using the spectool > you taught me. Good, I just wanted to make sure this is the case. > I re-did the patch and I had to comment out several more Db tests; as well > as some Collections and stuff. > > Anyway, the patch is remade in the SRPM and it now builds correctly. I still think that you mixed up some patches. Anyway I am glad it works for you. > > I have uploaded a new spec patch with > > - improved description > > - removed CFLAGS > > - improved (architecture independent) builddir detection > > - removed architecture limitation > > > > There is just one point left in my eyes: I see no reason why phalcon should > > not run on ppc and arm. If you know of any reason then readd the exclusive > > arch directive and add a comment why it won't run. > > I've emailed the author regarding these issues. I, also, asked his help in > reviewing the review; so he can clarify any pending points (like the CFLAGS) > and other matters. Good to hear that you are in close contact with upstream. Once you have your answeres we can finalize the specs. (btw. 32bit and 64bit build directory does not mean that a software is just meant for x86 cpu's and on github you can read "Phalcon PHP is written in C with platform independence in mind. As a result, Phalcon PHP is available on Microsoft Windows, GNU/Linux, Mac OS X", which sounds for me like it schould used wherever possible. And you can trust me, the cflags are just optimization flags ;) ). > Thank you once again. I appreciate your great effort and patience. Just drop me a note when you have some more infos. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RnzeKO0Twd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review