https://bugzilla.redhat.com/show_bug.cgi?id=989014 --- Comment #2 from Gerard Ryan <gerard@xxxxxxx> --- Thanks for the review! :) (In reply to gil cattaneo from comment #1) > Problem(s): > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > please, can ask if upstream to include license text file? Done. I've created a PR on Github to include it: https://github.com/jboss-jdf/jdf-stacks-client/pull/5 > [!]: Latest version is packaged. > https://github.com/jboss-jdf/jdf-stacks-client/archive/1.0.2.CR2.tar.gz > is available, consider upgrading I haven't packaged 1.0.2.CR2 because I think CR2 is probably considered a pre-release. Since I don't need anything specifically from the pre-release, I think having the latest 'Final'/stable is better for now. When 1.0.2.Final is released, I'll be sure to update to that :) > why dont use > https://github.com/jboss-jdf/jdf-stacks-client/archive/1.0.1.Final.tar.gz ? > regards I've done it this way because of the recommendations for using github tarballs as sources. See: https://fedoraproject.org/wiki/Packaging:SourceURL#Github -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZWjgpwEDrM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review