https://bugzilla.redhat.com/show_bug.cgi?id=985129 --- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx> --- There are several issues. For example, see comment 4. I hope I've found all of them, but I could not find a working package: * It would be helpful, if with each new release of your package, you provided a tested pair of src.rpm and spec file at a direct download location, so tools like fedora-review/wget/curl could access them directly: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Upload_Your_Package * Run rpmlint (or rpmlint -I for more helpful output) on the src.rpm and all built rpms. Feel free to ignore obvious false positives in the report, but fix anything else. Preferably add a comment here about whether/when you think what rpmlint reports is correct or incorrect. * The src.rpm package is incomplete and doesn't build at all yet. The reason is simple (but easy to miss when only skimming over the spec), it contains only the spec file, not the program script: cp: cannot stat 'text2nato': No such file or directory In the %install section, the spec file assumes that this file exists in the current directory, the "build directory", but there is nothing that copies it to that location. There is no %prep section in the spec file where you would set up the builddir and copy the file into it. Since you don't need the builddir, you don't need a %prep section. However, there is no "Source" tag in the spec file either, which would point at the download location for the text2nato script. Therefore, that file is not available and not included in your src.rpm yet. If, for example, you pointed the Source0 tag at the file's download URL (test it via "spectool -g text2nato.spec"), you could access the file via %{SOURCE0} in the %install section. https://fedoraproject.org/wiki/Packaging:SourceURL https://fedoraproject.org/wiki/Packaging:Guidelines#Tags https://fedoraproject.org/wiki/Packaging:ReviewGuidelines I can't tell how you've built the src.rpm so far, but there's a fundamental error in how you do it. * Bogus date in %changelog warning when building the rpm: "Fri Jul 23 2013" needs to be fixed to either Jul 26 or Tue. * cp -p text2nato %{_bindir}/ This is a line you've added recently. Why? The previous line that copies the file into %{buildroot}/%{_bindir} is fine. Files in %buildroot get included in the package via the %files section. This new line makes the build fail (when not building as "root"), and the package must install into the %buildroot directory, not into the system's file system. * Licensing: See comment 6. * %changelog: The RPM package changelog is for packaging related comments. Typically, you would not list all the changes in the text2nato script, but only anything relevant that has changed in the package. For a tiny package like this, that wouldn't be a lot. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs * Just a Perl script -> package should set "BuildArch: noarch" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8pG4B1EAYa&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review