https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #7 from Michael Schwendt <bugs.michael@xxxxxxx> --- Please run rpmlint (or rpmlint -I) on the src.rpm *and* all built rpms. Feel free to ignore obvious false positives, but fix reported issues and/or comment on them. https://fedoraproject.org/wiki/Packaging:ReviewGuidelines > Release: 1 Just to mention its existance: https://fedoraproject.org/wiki/Packaging:DistTag Depending on which build targets you'd like to release this package for, you could remove a few old items from the spec file. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > OPTIMIZE="$RPM_OPT_FLAGS" $RPM_OPT_FLAGS and %optflags are C/C++ compiler flags and don't apply to noarch Perl packages. > find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';' Not needed, pretty much useless (since empty dirs in buildroot don't cause any build error) and more of a hindrance in packages where you would like to include an empty directory actually. > %defattr(-,root,root,-) https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > it's not clear to me what the %changelog problem is The %changelog contains an entry for 2.28-1 whereas the linked spec file says 2.40-1. > But the guidelines for getting sponsored are a bit vague ("hang out on irc"). Well, that's just one way that works for some people to get to know other package maintainers and potential sponsors. IRC can be time-consuming and is not mandatory. Doing a few reviews can be one way to show that you know Fedora's Packaging Guidelines (and especially where to find them when it becomes necessary to look them up): http://fedoraproject.org/PackageReviewStatus/ https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Reviewing_packages -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Eobkx8CQ4S&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review