Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grass - GRASS (Geographic Resources Analysis Support System) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227646 ------- Additional Comments From cbalint@xxxxxxxxxx 2007-03-15 16:00 EST ------- updated. Spec URL: http://openrisc.rdsor.ro/grass.spec SRPM URL: http://openrisc.rdsor.ro/grass-6.2.1-12.src.rpm (In reply to comment #34) > Created an attachment (id=150146) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=150146&action=view) [edit] > grass.pc.in (with some fix) included. > For -11: > > * pkgconfig file: > - Well, > ------------------------------------------------ > Libs: -L%{libdir} -lgrass_I -lgrass_vask -lgrass_gmath -lgrass_gis > -lgrass_datetime -lgrass_gproj -lgrass_vect -lgrass_dbmibase -lgrass_dbmiclient > > ------------------------------------------------ > Actually this should be "-L${libdir}", not percent. This was my > typo, sorry... > - Other issues are: prefix, exec_prefix, libdir, includedir for grass.pc is > not correct. yes. right. > The attached grass.pc.in should work. included. > ? By the way, there are some other /usr/lib/libgrass_??.so which don't appear > > in grass.pc file. Would you know why? (perhaps because of some intention > of upstream). Dont know very exact. There are other projects e.g gdal can be builded against grass (i will enable it when grass will be mainstream) or there is olso a mapserver called project wich is compiled against grass-devel so i guess some of libs may be internal and some external as i figured out :-D but not 100% sure right now. (sorry for this) (i would like to include mapserver olso, as part of php-* extensions for apache !!! , really, really nice project , it can outperform comercial soultions from ESRI Inc. in the area of web-publish gis or maps http://mapserver.gis.umn.edu/ if want see project against grass libs) > - And for gdal.pc, the correct one is > ------------------------------------------------ > Libs: -L${libdir} -lgdal > ------------------------------------------------ > ... my bad ... Yes that one was already noticed by me, submitted upstream -14 gdal is fine. > * Optflags > ? Not bad, and I didn't notice this, however, fedora optflags seems to be > passed twice. > ------------------------------------------------ > make[2]: Entering directory `/builddir/build/BUILD/grass-6.2.1/lib/datetime' > gcc -I/builddir/build/BUILD/grass-6.2.1/dist.i686-redhat-linux-gnu/include -O2 > -g -pipe -Wall -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 > -march=i386 -mtune=generic -fasynchronous-unwind-tables -O2 -g -pipe -Wall > -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 > -mtune=generic -fasynchronous-unwind-tables -fPIC > -DPACKAGE=\""grasslibs"\" -DPACKAGE=\""grasslibs"\" > -I/builddir/build/BUILD/grass-6.2.1/dist.i686-redhat-linux-gnu/include \ > -o OBJ.i686-redhat-linux-gnu/between.o -c between.c > ------------------------------------------------ fixed. > + Timestamps are actually fixed correctly. > + rpmlint warnings can now all be ignored. Thx a lot for fix ! > Well, again I will try to check all source files > (although there are 5000+ files...) I hope that this review > is now approaching to the goal. Tasaka, if you take it easy, will be a loss if this grass will be not submited in this seasson :-) I got already a long list to fix upstream ... Anyway must thank to you a lot for helping me out, you was very kind at all ! and olso Patrice patience and helpout was great ! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review