https://bugzilla.redhat.com/show_bug.cgi?id=658754 --- Comment #39 from Esen Sagynov <esen.sagynov@xxxxxxx> --- Response to Michael's comments. The spec file has been updated with the following changes. > %global file_version 1 > Version: %{cubrid_version}.%{build_version} > %global cubrid_vendor Search Solution Corporation > BuildRequires: glibc-devel > Group: Development/Libraries > %post devel -p /sbin/ldconfig > %postun devel -p /sbin/ldconfig > %preun devel Removed/updated. > %package devel > Requires: %{name} = %{cubrid_version}.%{build_version} > That isn't strict enough for how Fedora does it: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > Imagine you release a fix where you want the -devel package (or other subpackages) to be in sync with the base package. Updated. > %global debug_package %{nil} > Why that? We had to add this line because it was gaving an RPM building error "no build id note found in" for cub_cmhttpd. > %build > %ifarch x86_64 > CFLAGS=" -m64 " > CUBRID_COMMON_CONFIGURE="${CUBRID_COMMON_CONFIGURE} --enable-64bit" > %endif > What about other 64-bit targets? Which are the other 64-bit targets you are referring to? > ./autogen.sh > ./configure ${CUBRID_COMMON_CONFIGURE} > autogen.sh but no %configure macro usage? See "rpm --eval %configure". If %configure cannot be used with this configure script, please add a comment in the spec file. Added the following comment: # %configure macro is disabled/missing because not all options are supported in CUBRID. # For example, when passing "bindir" or "libdir" parameter will lead to an error # (not supported feature). > %install > It's odd that this section is so long. Why is it necessary to install/adjust so many things here after "make install"? Why doesn't "make install" do all that? Currently, in the original CUBRID spec "make install" installs all files in one directory. To submit to Fedora/Ubuntu we've created new specs (this spec for Fedora). In the new spec we've tried to place all files in their proper locations: (conf files in /etc/conf/cubrid, the variable files to /var/cubrid, the executables to /usr/bin, the libraries to /usr/lib or /usr/lib64 depending on architecture and so forth). This is why the install section is long. > %post demodb > /sbin/ldconfig > It contains only files below /usr/share. > %postun demodb > /sbin/ldconfig > Same here. Updated. > find %{buildroot} -size 0 -delete > Hopefully you'll never need to include an empty file or touch one to include it as %ghost. The source may have empty files (for example some optional configuration files). This was to remove warnings and possible empty files from the source. > The %files sections list many files with very generic file names (even headers such as %{_includedir}/dbi.h). It'll be a lot of fun to avoid conflicts with other packages. Yes, there are files which we have found to have similar names, but at this moment it's not possible to change them. If any serious conflict is found, we will put resources to fix them. However, if you have any suggestion to avoid name conflicts, please let us know. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dO4wPpHceZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review