Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iwlwifi-firmware - Microcode for Intel® PRO/Wireless 3945 A/B/G network adaptors https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096 tmz@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tmz@xxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tmz@xxxxxxxxx 2007-03-15 14:55 EST ------- Hi Matthias, This package looks good. Here's a review. (I have one of these cards so I'm looking forward to seeing a proper driver included in F7 (or so). Thanks for packaging the firmware!) OK - rpmlint output $ rpmlint iwlwifi-firmware-2.14.1-3.src.rpm W: iwlwifi-firmware invalid-license Redistributable, no modification permitted E: iwlwifi-firmware hardcoded-library-path in %{buildroot}/lib/firmware/iwlwifi-3945.ucode E: iwlwifi-firmware hardcoded-library-path in /lib/firmware/*.ucode All of these can be safely ignored for firmware packages OK - follows naming guidelines (for firmware packages) OK - specfile matches base package %{name} OK - meets the Packaging Guidelines OK - license is acceptable (for firmware packages) OK - licence field is appropriate (for firmware packages) OK - license file is included in %doc OK - specfile is in American English OK - specfile is legible OK - source matches upstream (sha1: 29e90e7a6c5fe06eaad3780235a77ce0411d132f) OK - package contains no duplicate files OK - permissions on files set correctly OK - specfile has proper %clean section OK - consistent use of macros OK - contains code or permissible content OK - %doc files don't affect runtime OK - doesn't own files or directories already owned by other packages ACCEPT -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review