[Bug 975309] Review Request: libcutl - C++ utility library from Code Synthesis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=975309

--- Comment #10 from Dave Johansen <davejohansen@xxxxxxxxx> ---
> > I tried following those instructions, but they appear to be outdated
> > and the link goes to Trac page that doesn't appear related to setting
> > up hosting.
>
> Hmmm, what makes you think so?
>
>
> > but what's the proper instructions?
>
> They are accurate:
>
> | you can request sufficient access to use fedorapeople space
> | by visiting the sponsors trac instance and filing a ticket in
> | the "Initial package hosting request" component.
>
> https://fedorahosted.org/packager-sponsors/
>  -> https://fedorahosted.org/packager-sponsors/newticket
>    -> Component "Initial package hosting request"

Sorry! I guess that I didn't read the last part of the last line well enough or
something, because I was expecting there to be instructions on the linked to
wiki. Stupid user error on my part.


> > binutils, glibc-common, net-tools and pkgconfig because
> > auto-buildrequires recommended them. Should I include those?

> You should drop
>  * binutils, because it's required by gcc and rpm-build
>  * glibc-common, because it's required by glibc, which is too essential

Fixed

> > net-tools

> Unusual. But what is it used for during the build?

That was just listed in the auto-buildrequires output when I ran it on CentOS
6. When I just re-ran auto-buildrequires on Fedora 19, it didn't list it, so I
just removed it.


> > %{_includedir}/cutl/
> > %{_includedir}/cutl/*
> >
> > with
> >
> > %{_includedir}/cutl/
>
> That's related to what I've pointed out before. Before my comment, there
> only was /usr/include/cutl/* which didn't include the directory
> /usr/include/cutl
>
> I recommend revisiting the
>   http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes
> page section, because it explains this in detail. If those instructions aren't
> enough, please tell what is unclear.

Sorry again! Another dumb mistake on my part. I read the first part and saw
that I needed to added the line to include the directory, so I did that. I
guess I didn't read the rest of that section well enough and didn't realize
that including the directory also included the contents, so I fixed that now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lV239IIVC4&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]