https://bugzilla.redhat.com/show_bug.cgi?id=987204 Peter Hutterer <peter.hutterer@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx Flags| |needinfo?(bugs.michael@gmx. | |net) --- Comment #5 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> --- (In reply to Michael Schwendt from comment #4) > > %package devel > > Requires: %{name} = %{version}-%{release} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package thanks, will be fixed. > > Requires: pkgconfig > > For EL5? Else there are automatic Requires/Provides. Do you have a reference there? I can find sources that say I'd have to change this to BuildRequires: pkgconfig instead and (one from 2006) that states I need the above line. I'd be interested to find what the official stance is atm, I've got quite a few packages with this line (this spec file was copied from another one, which was copied from another, which...) > > %files devel > > %doc COPYING > > It's not necessary to duplicate the file here. > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Subpackage_Licensing ACK > > libevdev-0.2/doc/* > > Documentation that could be generated with Doxygen. I've intentionally not packaged this as a -doc packge. the source is available online which I think is a better approach here. http://www.freedesktop.org/software/libevdev/doc/ > > BuildRequires: check-devel > > If one executes "make check", in GNOME Shell the "Oh no! Something has gone > wrong" screen appears" briefly. that's a bug in mutter and gnome-shell that I haven't fixed yet. the tests create a lot of test devices very quickly, mutter simply can't handle that. unrelated to this package though, you'd get the same issue if you're really fast at unplugging USB devices :) > > /usr/lib64/pkgconfig/libevdev.pc > > There's an undefined Version in that file, which makes pkgconfig version > checks impossible. The defined Name doesn't match the file name, btw. whoah, good catch. fixed locally, will upload the new versions asap once upstream is released with those fixes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lpYgP8uHCC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review