Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ettercap - Network traffic sniffer/analyser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-15 13:00 EST ------- One small error at the first glance: you've split each one of the "alternatives install" instructions on two lines, but forgot to end the first line with a continuation marker. A more important error are the typos in the same lines, each one of the {_bindir} should have been %{_bindir}; same error is present in the "alternatives remove" lines Also, there is no need to use both "Requires: alternatives" and "Requires(post): %{_sbindir}/alternatives / Requires(preun): %{_sbindir}/alternatives" (second Requires line in the main package) Since you'll have to edit the spec anyway, I have a few additional suggestions (feel free to ignore them, they are just that, suggestions) - in the %doc line, replace doc with doc/ in order to make it clear it's a directory - rename the cryptic ettercap.ettercap to ettercap-tui - dump the custom defined ettercapdir macro, it's used only once, in the %files section, so there is no saving after all -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review