https://bugzilla.redhat.com/show_bug.cgi?id=976770 --- Comment #3 from Rich Mattes <richmattes@xxxxxxxxx> --- rpmlint provides some feedback: Checking: sstp-client-1.0.9-1.fc19.x86_64.rpm sstp-client-devel-1.0.9-1.fc19.x86_64.rpm sstp-client.x86_64: E: explicit-lib-dependency libevent sstp-client.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/sstpc ['/usr/lib64'] sstp-client.x86_64: E: missing-call-to-setgroups /usr/sbin/sstpc sstp-client.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/pppd/2.4.5/sstp-pppd-plugin.so ['/usr/lib64'] sstp-client-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 4 errors, 1 warnings. First off, the shared libs need to have their rpaths removed as per [1]. Once that's done, rpmlint will probably complain that there's no ldconfig being called. You should specify %post and %postun -p /sbin/ldconfig if that's the case Libevent doesn't need to be an explicit Requires: in the package; libsstp_api-0.so links to libevent so rpm will generate the dependency automatically. ldd ./libsstp_api-0.so |grep libevent libevent-2.0.so.5 => /lib64/libevent-2.0.so.5 (0x00007f334a29b000) libsstp_api.so is a symlink to libsstp_api-0.so, which is the real library. The libsstp_api.so symlink should probably be in the -devel package. Finally, the missing-call-to-setgroups error is something you should bring up upstream. rpmlint is pointing this out as an error, but I'm not sure which packaging guideline this violates (though it does look like a security issue that needs to be addressed.) [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PZ55AC9vC5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review