https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #2 from Eric Smith <spacewar@xxxxxxxxx> --- Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-2.fc19.src.rpm Thanks for reviewing! 1. I prefer to keep github Source0 for reasons we've discussed in other package reviews. If you feel strongly that this needs to change, let me know, and I'll do it. 2. I don't understand what you mean by "missed a unowned dir"; the output of "rpm -qlvp" looks good to me. It contains (and owns) the directory, the directory contents, and the egg-info, and doesn't appear to contain anything it shouldn't. In fact, timestamps aside, I get exactly the same listing whether I use my original files section or the one you propose. However, I've made the change. (If we didn't use a BuildRoot, it certainly wouldn't work to glob all of python_sitelib, but with a BuildRoot there doesn't seem to be any issue with it, and it appears that a lot of RPMs of Python libraries do that.) 3. The purpose of requiring hyphen-en is that I want to add a %check section that does a subset of the upstream unit tests, and wanted to have one language available for that. However, I haven't added that yet, and it would be a BuildRequires rather than a Requires, so I've dropped the Requires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TQ8f0qw1GY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review