https://bugzilla.redhat.com/show_bug.cgi?id=985967 --- Comment #6 from Cleber Rodrigues <crosa@xxxxxxxxxx> --- (In reply to Eduardo Echeverria from comment #3) > Hi clever: Thanks for calling me "clever", but judging from the amount of mistakes here I wouldn't call myself that :) > > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %endif isn't neccesary in newest versions of Fedora, please remove from the > spec. > As suggested earlier, I'm removing this block altogether. > Please provide the full url in Source0 (https://github.com/clebergnu/arc) , > for this, handle the url following the recommendations exposed in > https://fedoraproject.org/wiki/Packaging:SourceURL#Github Is is possible to only use the version tag for the Source URL, such as: Source0: https://github.com/clebergnu/%{shortname}/archive/v%{version}.tar.gz Instead of the commit hash? Since I plan to also host the Fedora spec file on the upstream repo, this would create an "egg and chicken" kind of problem. > > Use in BuildRequires: python2-devel instead of python >= 2.7, see > http://fedoraproject.org/wiki/Packaging:Python#BuildRequires > > Requires: python >= 2.7 OK! Looks like I got away with depending only on python (instead of -devel) because I included the site lib macro. > > - %clean isn't needed OK > - BuildRoot isn't needed OK > - cleaning of buildroot in %install isn't needed OK > - %defattr is not needed OK > all this only are necessary for el5, see > https://fedoraproject.org/wiki/EPEL:Packaging > > the version of python in el5 is 2.4, and in el6 is 2.6, afaik, your package > needs 2.7, so el5/6 not are valid versions for your package, Just for > curiosity,since you are the programmer, don't works in python2.6? No, it's designed to work with python 2.7 only. The reason is that I took care to also make it source compatible with python 3. At a later time I want to also make python 3 packages out of this same spec. > > rpmlint out: > > python-arc.noarch: E: description-line-too-long C Arc is the Autotest RPC > Client, a library and command line API for controlling an Autotest RPC > Server. > > - please not exceed your description of the 80 characters per line New description: Arc is the Autotest RPC Client. It provides libraries and tools that interact with an Autotest RPC Server. It allows one to send test jobs, add test hosts, query available tests, etc. > > python-arc.noarch: W: no-documentation > Add license, README, etc in %doc (btw, not is included in your spec) OK. BTW, is it OK to use "README.md" as the "official README"? > > python-arc.noarch: E: incorrect-fsf-address > /usr/lib/python2.7/site-packages/arc/jsonrpc.py > the license header haven't a fsf updated address, that would a minor > problem, if it were not because also part of a library from another project, > this in fedora have a clear policy, see > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Since this is a "library" with about 60 lines of code that was modified for arc's requirements, and it's not packaged in Fedora, I assume it's OK to "bundle" it, but update the FSF address to remove this noise. Right? > > please fix this permissions > python-arc.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/arc/connection_unittest.py 0644L This file should not have made into the SRPM because it should not have made into the tarball in the first place. I was generating the tarball with "python setup.py sdist", but I'll now use the github generated tarball to avoid shipping files that are not tracked upstream. > /usr/bin/env > python-arc.noarch: E: wrong-script-interpreter Fixed. > /usr/lib/python2.7/site-packages/arc/cli/app.py /usr/bin/env/python > python-arc.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/arc/cli/app.py 0644L /usr/bin/env/python Fixed. > python-arc.noarch: W: no-manual-page-for-binary arcli > > A question, why don't build the documentation of the package? That's a good question. I'll include the docs and add the arcli manpage. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nXYQtSvMwQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review