https://bugzilla.redhat.com/show_bug.cgi?id=985622 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |extras-qa@xxxxxxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> --- * I understand that specs cannot be run at the moment, but perhaps would be better to fix the spec file in the way that it could run them when the deps are fulfilled. That probably requires running the specs in the right directory: pushd .%{gem_instdir} rspec -Ilib spec popd and requiring RSpec as BuildRequires: BuildRequires: rubygem(rspec) (both within your 0%{?enable_tests} condition). Otherwise the spec matches the guidelines, rpmlint doesn't complain, package builds, installs and runs fine so I am APPROVING. Please, fix the issue above (or delete the conditions whatsoever) before pushing it and don't forget to bump the release. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N6HTTETQGg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review