https://bugzilla.redhat.com/show_bug.cgi?id=985358 --- Comment #2 from Axilleas Pipinellis <axilleas@xxxxxxxxxxxx> --- (In reply to Ricky Elrod from comment #1) > Here's a first go at this. Major issues are at the top, there's a few more > things (like not using all the fancy rubygem-devel macros) inline, that you > might be able to fix too. > Hi Ricky! Thanks for taking the time to review this. This is one of my first packages so I might have a few questions. Comments inline. > - gems should require rubygems package > Note: Requires: rubygems missing in rubygem-hashie-doc > See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems > As far as I know, doc subpackages depend on the real package which in turns Requires: ruby(rubygems). So adding rubygems to -doc isn't really needed. Am I wrong? > - If you're building for F18- you need to conditionalize ruby(abi): > > %if 0%{?fedora} >= 19 > Requires: ruby(release) > %else > Requires: ruby(abi) >= 1.9.1 > %endif I am not building for F18 at this point, but if you think it's better to support F18 as well, I guess I could make this change. > - Fully version the -doc subpackage: > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem- > hashie-doc As per the guidelines, this would be the case of an arch dependent package [0]. Since this is noarch I think the %{?_isa} doesn't apply. Correct me if I am wrong. > ===== MUST items ===== > > Generic: > > [!]: Package requires other packages for directories it uses. I don't understand how that applies to the spec. Could you please explain it? > [!]: Requires correct, justified where necessary. What else am I missing from Requires? hashie doesn't have any other gem dependencies so the only Requires should be ruby(release) and ruby(rubygems), right? > ===== SHOULD items ===== > > Ruby: > [!]: Specfile should use macros from rubygem-devel package. > Note: The specfile doesn't use these macros: %doc %{gem_docdir}, > %exclude %{gem_cache}, %{gem_spec}, %{gem_libdir} I don't understand why fedora-review marked these as not being used. I have all of them in my specfile... [0] https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YyMdqQvYy4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review