https://bugzilla.redhat.com/show_bug.cgi?id=915144 --- Comment #21 from Dmitrij S. Kryzhevich <krege@xxxxxxx> --- Sorry for the delay, again. (In reply to Björn Esser from comment #18) > - bogus date in %changelog: Wed Mar 14 2013 Dmitrij S. Kryzhevich 2.7.5-7 > - bogus date in %changelog: Thu Mar 13 2013 Dmitrij S. Kryzhevich 2.7.5-6 > - bogus date in %changelog: Thu Mar 13 2013 Dmitrij S. Kryzhevich 2.7.5-5 > > ---> fix this, please Done. > - manual-page-warning rasmol.1x.gz 1: warning: macro `PU' not defined > - manual-page-warning rasmol.1x.gz 4119: warning: macro `false',' not defined > > ---> please fix this, e.g. with patch I'm trying to understang what is called one after another in Makefile. rasmol tar contain formated file AND man file AND compressed man file. > - rasmol.x86_64: E: incorrect-fsf-address /usr/share/doc/rasmol-2.7.5/GPL > > ---> please inform upstream and ask for including recent rev. > of that document Done (it was done before). > ---> LDFLAGS are ommitted on linking Done. > [!]: License file installed when any subpackage combination is installed. > > ---> add %doc GPL to -doc-pkg Done. > [!]: Large documentation must go in a -doc subpackage. > Note: Documentation size is 481280 bytes in 20 files. > > ---> you should move all %doc, but GPL, to doc-pkg Hm... Changelog and readme? All doc is already in -doc. What do you mean? > [!]: Packages should try to preserve timestamps of original installed files. > > ---> add -p switch to install-commands, please. Done. Spec URL: http://krege.fedorapeople.org/rasmol/rasmol.spec SRPM URL: http://krege.fedorapeople.org/rasmol/rasmol-2.7.5-8.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3BofGdc6O5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review