https://bugzilla.redhat.com/show_bug.cgi?id=985814 --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to gil cattaneo from comment #4) > - Packages have proper BuildRequires/Requires on jpackage-utils > Note: Maven packages do not need to (Build)Require jpackage-utils. It is > pulled in by maven-local > See: https://fedoraproject.org/wiki/Packaging:Java > FIXME see comment 2 Fixed. > - Maven packages should use new style packaging > Note: If possible update your package to latest guidelines > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven > SKIP Will do once it's built also for Fedora 18. > - If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package is included in %doc. > Note: Cannot find LICENSE.md in rpm(s) > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > FIXME install license file e.g. MPL guacamole-ext/LICENSE Added, I will ask upstream to put all licenses in the root project folder: guacamole/COPYING guacamole-common-js/LICENSE doc/guacamole-example/COPYING guacamole-ext/LICENSE guacamole-common/LICENSE > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "AGPL (v3 or later)", "MPL (v1.1) GPL (unversioned/unknown version)", > "Unknown or generated". 39 files have unknown license. > FIXME ADD: AGPLv3+ to license tag e.g. License: MPLv1.1 or GPL+ > or AGPLv3+ > AGPL (v3 or later) Added, I was not aware that upstream changed license for this release. > [!]: If the package is under multiple licenses, the licensing breakdown must > be documented in the spec. Spec URL: http://slaanesh.fedorapeople.org/guacamole/guacamole-client.spec SRPM URL: http://slaanesh.fedorapeople.org/guacamole/guacamole-client-0.8.2-2.fc19.src.rpm Thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5mHVIjafou&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review