https://bugzilla.redhat.com/show_bug.cgi?id=979677 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build for f20 is successful + rpmlint on rpms gave perl-CPANPLUS-Dist-Fedora.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end perl-CPANPLUS-Dist-Fedora.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end 2 packages and 0 specfiles checked; 0 errors, 2 warnings. => Looks good + Source verified with upstream as (sha256sum) srpm tarball: 18dce03a3a49ba34db87b519d0d3d5b4229a01d0ff8e170bd04505ca883c7442 upstream tarball: 18dce03a3a49ba34db87b519d0d3d5b4229a01d0ff8e170bd04505ca883c7442 + license is valid "GPL+ or Artistic" + make test gave All tests successful. Files=4, Tests=4, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.31 cusr 0.03 csys = 0.37 CPU) + Package perl-CPANPLUS-Dist-Fedora-0.0.4-1.fc20.noarch Provides: perl(CPANPLUS::Dist::Fedora) = 0.0.4 perl-CPANPLUS-Dist-Fedora = 0.0.4-1.fc20 Requires: perl(CPANPLUS::Dist::Base) perl(CPANPLUS::Error) perl(Cwd) perl(File::Basename) perl(File::Copy) perl(IPC::Cmd) perl(List::Util) perl(POSIX) perl(Pod::POM) perl(Pod::POM::View::Text) perl(Template) perl(Text::Wrap) perl(base) perl(strict) perl(warnings) Suggestions: 1) BR: perl not needed 2) Let the rpm generate Requires: automatically for binary package. Remove manually written Requires: in spec file. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w8QTFh9uqt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review