https://bugzilla.redhat.com/show_bug.cgi?id=982428 --- Comment #6 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- Thanks Pádraig for the new package. Manual Review: ~~~~~~~~~~~~~~ Short: Everything looks good. Long: ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - ASL 2.0 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [-]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/python-oslo-sphinx/licensecheck.txt ==== - $ cat /home/kashyap/rpmbuild/SRPMS/python-oslo-sphinx/licensecheck.txt Apache (v2.0) ------------- /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/oslo.sphinx-1.0/oslo/__init__.py /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/oslo.sphinx-1.0/oslo/sphinx/__init__.py /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/oslo.sphinx-1.0/setup.py ==== [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. - This is OK. Python: [x]: Python eggs must not download any dependencies during the build process. - $ cat upstream-unpacked/Source0/oslo.sphinx-1.0/oslo.sphinx.egg-info/dependency_links.txt - i.e. No dependencies listed. [-]: A package which is used by another package via an egg interface should provide egg info. - $ cd upstream-unpacked/Source0/oslo.sphinx-1.0/ - $ tree oslo.sphinx.egg-info/ oslo.sphinx.egg-info/ ├── dependency_links.txt ├── namespace_packages.txt ├── not-zip-safe ├── PKG-INFO ├── SOURCES.txt └── top_level.txt [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. - Upstream doesn't provide tests yet. [x]: Packages should try to preserve timestamps of original installed files. Rpmlint ------- Checking: python-oslo-sphinx-1.0-2.fc20.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-oslo-sphinx python-oslo-sphinx.noarch: W: incoherent-version-in-changelog 2013.1-0.1 ['1.0-1', '1.0-1'] 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python-oslo-sphinx (rpmlib, GLIBC filtered): python(abi) python-setuptools Provides -------- python-oslo-sphinx: python-oslo-sphinx Source checksums ---------------- http://tarballs.openstack.org/oslo.sphinx/oslo.sphinx-1.0.tar.gz : CHECKSUM(SHA256) this package : 222b76cc39ca6ed947049d348ff228cd851789827d31891dbfc61ada87704635 CHECKSUM(SHA256) upstream package : 222b76cc39ca6ed947049d348ff228cd851789827d31891dbfc61ada87704635 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D7BQj9rGCO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review