https://bugzilla.redhat.com/show_bug.cgi?id=986550 --- Comment #6 from Christopher Meng <cickumqt@xxxxxxxxx> --- Issue: 1. Remove %defattr(-,root,root,-) in the %files section. Suggestions: 1. SOrt things like this: Name: python-xmp-toolkit Version: 1.0.2 Release: 2%{?dist} Summary: Python XMP Toolkit for working with metadata Group: Development/Libraries License: BSD URL: http://code.google.com/p/python-xmp-toolkit/ Source0: https://pypi.python.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: python2-devel BuildRequires: python-setuptools Requires: exempi You don't need to leave too many empty lines :) 2. %setup -q -n %{name}-%{version} can be safely replaced by %setup -q 3. You can remove VERSION file in doc as it's useless. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5PhZ41RMtQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review