[Bug 911040] Review Request: nodejs-muffin - Node.js module with handy helpers for building Cakefiles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=911040

--- Comment #5 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
(In reply to Marcelo Barbosa from comment #4)
>    Your package not declared some directories created, see:
> 
> deps/ 
> lib/
> 
>    Both directories should be in %files

Both of these directories are already in %files.

47 cp -pr package.json deps/ lib/ \
48     %{buildroot}%{nodejs_sitelib}/muffin
...
57 %files
58 %doc Readme.md docs/
59 %{nodejs_sitelib}/muffin


> I think could check also if the variable "BuildRequire: nodejs-packaging"
> should not be "BuildRequires: nodejs-devel"
> ?http://fedoraproject.org/wiki/Packaging:Node.js#BuildRequires

So this isn't actually properly documented yet. The new guidelines actually
recommend nodejs-packaging. You can see the draft here:

https://fedoraproject.org/wiki/User:Patches/PackagingDrafts/NodeJS#BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bUQ57heMzt&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]