https://bugzilla.redhat.com/show_bug.cgi?id=985814 --- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local See: https://fedoraproject.org/wiki/Packaging:Java FIXME see comment 2 - Maven packages should use new style packaging Note: If possible update your package to latest guidelines See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven SKIP - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in guacamole See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage SKIP - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE.md in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text FIXME install license file e.g. MPL guacamole-ext/LICENSE ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in guacamole , guacamole-javadoc [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "AGPL (v3 or later)", "MPL (v1.1) GPL (unversioned/unknown version)", "Unknown or generated". 39 files have unknown license. FIXME ADD: AGPLv3+ to license tag e.g. License: MPLv1.1 or GPL+ or AGPLv3+ AGPL (v3 or later) ------------------ doc/guacamole-example/src/main/java/net/sourceforge/guacamole/net/example/DummyGuacamoleTunnelServlet.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/AuthenticatingHttpServlet.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/BasicFileAuthenticationProvider.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/BasicGuacamoleTunnelServlet.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/BasicLogin.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/BasicLogout.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/GuacamoleClassLoader.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/ProtocolInfo.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/ProtocolParameter.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/ProtocolParameterOption.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/WebSocketSupportLoader.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/auth/Authorization.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/auth/UserMapping.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/connections/Create.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/connections/Delete.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/connections/List.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/connections/Update.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/permissions/List.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/protocols/List.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/users/Create.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/users/Delete.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/users/List.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/crud/users/Update.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/event/SessionListenerCollection.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/properties/AuthenticationProviderProperty.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/properties/BasicGuacamoleProperties.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/properties/EventListenersProperty.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/DocumentHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/TagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/protocol/OptionTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/protocol/ParamTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/protocol/ProtocolTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/user_mapping/AuthorizeTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/user_mapping/ConnectionTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/user_mapping/ParamTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/user_mapping/ProtocolTagHandler.java guacamole/src/main/java/net/sourceforge/guacamole/net/basic/xml/user_mapping/UserMappingTagHandler.java [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 2 files. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: guacamole-0.8.2-1.fc20.noarch.rpm guacamole-javadoc-0.8.2-1.fc20.noarch.rpm guacamole.noarch: W: name-repeated-in-summary C Guacamole guacamole.noarch: W: spelling-error %description -l en_US guacd -> guard guacamole.noarch: W: spelling-error %description -l en_US libguac -> lingual guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/commons-logging.jar /usr/share/java/commons-logging.jar guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/slf4j-api.jar /usr/share/java/slf4j/slf4j-api.jar guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/slf4j-jcl.jar /usr/share/java/slf4j/slf4j-jcl.jar guacamole.noarch: W: dangerous-command-in-%pretrans rm 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint guacamole-javadoc guacamole guacamole.noarch: W: name-repeated-in-summary C Guacamole guacamole.noarch: W: spelling-error %description -l en_US guacd -> guard guacamole.noarch: W: spelling-error %description -l en_US libguac -> lingual guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/commons-logging.jar /usr/share/java/commons-logging.jar guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/slf4j-api.jar /usr/share/java/slf4j/slf4j-api.jar guacamole.noarch: W: dangling-symlink /usr/share/tomcat/webapps/guacamole/WEB-INF/lib/slf4j-jcl.jar /usr/share/java/slf4j/slf4j-jcl.jar guacamole.noarch: W: dangerous-command-in-%pretrans rm 2 packages and 0 specfiles checked; 0 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- guacamole-javadoc (rpmlib, GLIBC filtered): jpackage-utils guacamole (rpmlib, GLIBC filtered): /bin/sh apache-commons-logging config(guacamole) java jpackage-utils slf4j tomcat tomcat-native Provides -------- guacamole-javadoc: guacamole-javadoc guacamole: config(guacamole) guacamole guacamole-common guacamole-common-js guacamole-ext Source checksums ---------------- http://guac-dev.org/pub/dist/source/guacamole-client-0.8.2.tar.gz : CHECKSUM(SHA256) this package : 6ca5928f29232c8f70f5b6de5b19e3e1dcf64a80319ab27002e84f8f11bb92aa CHECKSUM(SHA256) upstream package : 6ca5928f29232c8f70f5b6de5b19e3e1dcf64a80319ab27002e84f8f11bb92aa Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-19-i386 Command line :/usr/bin/fedora-review -vpn guacamole-client -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WgVYa9daL4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review