[Bug 985753] Review Request: dfuzzer - Fuzzer for processes connected to D-Bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=985753

--- Comment #4 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
You must use a valid url for the Source0 in the spec (that is to say, the url
of the pristine sources), in this case, the project is published in Github,
please see https://fedoraproject.org/wiki/Packaging:SourceURL#Github, for see
an example of how proceed 

Don't use both %{buildroot} and $RPM_BUILD_ROOT see
http://fedoraproject.org/wiki/Packaging/Guidelines#macros

rpmlint out 
dfuzzer.x86_64: W: no-documentation
Please add the license, README, etc, (btw, your spec not include %doc section,
please add it)

dfuzzer.x86_64: E: non-standard-executable-perm /usr/bin/dfuzzer 0775L
Fix the permission. btw, you can install directly, by example, you can do
mkdir -p %{buildroot}%{_bindir}/
install -pm 0755 dfuzzer %{buildroot}%{_bindir}/%{name}

dfuzzer.x86_64: W: no-manual-page-for-binary dfuzzer
it would be useful to have it, and have sense because is a CLI tool

the package don't honor the applicable compiler flags, see
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags 

Your package contains documentation that can be build via doxygen please do it

Please remove the superfluous comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y6irBofN9J&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]