https://bugzilla.redhat.com/show_bug.cgi?id=985967 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi clever: %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif isn't neccesary in newest versions of Fedora, please remove from the spec. Please provide the full url in Source0 (https://github.com/clebergnu/arc) , for this, handle the url following the recommendations exposed in https://fedoraproject.org/wiki/Packaging:SourceURL#Github Use in BuildRequires: python2-devel instead of python >= 2.7, see http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Requires: python >= 2.7 - %clean isn't needed - BuildRoot isn't needed - cleaning of buildroot in %install isn't needed - %defattr is not needed all this only are necessary for el5, see https://fedoraproject.org/wiki/EPEL:Packaging the version of python in el5 is 2.4, and in el6 is 2.6, afaik, your package needs 2.7, so el5/6 not are valid versions for your package, Just for curiosity,since you are the programmer, don't works in python2.6? rpmlint out: python-arc.noarch: E: description-line-too-long C Arc is the Autotest RPC Client, a library and command line API for controlling an Autotest RPC Server. - please not exceed your description of the 80 characters per line python-arc.noarch: W: no-documentation Add license, README, etc in %doc (btw, not is included in your spec) python-arc.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/arc/jsonrpc.py the license header haven't a fsf updated address, that would a minor problem, if it were not because also part of a library from another project, this in fedora have a clear policy, see https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries please fix this permissions python-arc.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/arc/connection_unittest.py 0644L /usr/bin/env python-arc.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/arc/cli/app.py /usr/bin/env/python python-arc.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/arc/cli/app.py 0644L /usr/bin/env/python python-arc.noarch: W: no-manual-page-for-binary arcli A question, why don't build the documentation of the package? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NmZlPcK3V8&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review