https://bugzilla.redhat.com/show_bug.cgi?id=977208 --- Comment #24 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- (In reply to Roman Mohr from comment #23) > Created attachment 776248 [details] > better description and updated spec file for running unittests > > (In reply to Renich Bon Ciric from comment #21) > > (In reply to Roman Mohr from comment #20) > > > Created attachment 773914 [details] > > > Patch to run most of the non-db-dependent unit tests > > > > > > Apply in combination with attachment 773907 [details] > > > > Thank you, Roman, for your hard work and collaboration. > > > > You are welcome :) > > > Here's what I got: > > > > Patch #0 (php-phalcon-phpunit.patch): > > + /usr/bin/cat /builddir/build/SOURCES/php-phalcon-phpunit.patch > > + /usr/bin/patch -p0 --fuzz=0 > > can't find file to patch at input line 3 > > Perhaps you used the wrong -p or --strip option? > > The text leading up to this was: > > -------------------------- > > |--- unit-tests/phpunit.xml.orig 2013-07-15 22:43:31.311938857 +0200 > > |+++ unit-tests/phpunit.xml.orig 2013-07-15 22:44:08.794605062 +0200 > > -------------------------- > Strange, where does that header com from? The header of the uploaded patch > looks like this: > > --- unit-tests/phpunit.xml.orig 2013-07-15 22:43:31.311938857 +0200 > +++ unit-tests/phpunit.xml 2013-07-15 22:44:08.794605062 +0200 > > It should be enough that the correct file name is in the '+++' line. > > (In reply to Renich Bon Ciric from comment #22) > > Ok, removed .orig from the header of the file and I got this now: > > > > Patch #0 (php-phalcon-phpunit.patch): > > + /usr/bin/cat /builddir/build/SOURCES/php-phalcon-phpunit.patch > > + /usr/bin/patch -p0 --fuzz=0 > > patching file unit-tests/phpunit.xml > > Hunk #1 FAILED at 14. > > Hunk #2 FAILED at 31. > > Hunk #3 FAILED at 63. > > The official github tag is not commit b72745 used by us. I am quite sure > that you are using an old archive. Please place the correct source tar.gz in > your SOURCES folder. Well, actually, we're using a tag now: v1.2.0. Also, I am using the spectool you taught me. I re-did the patch and I had to comment out several more Db tests; as well as some Collections and stuff. Anyway, the patch is remade in the SRPM and it now builds correctly. > I have uploaded a new spec patch with > - improved description > - removed CFLAGS > - improved (architecture independent) builddir detection > - removed architecture limitation > > There is just one point left in my eyes: I see no reason why phalcon should > not run on ppc and arm. If you know of any reason then readd the exclusive > arch directive and add a comment why it won't run. I've emailed the author regarding these issues. I, also, asked his help in reviewing the review; so he can clarify any pending points (like the CFLAGS) and other matters. Thank you once again. I appreciate your great effort and patience. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7j1zVwHPh4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review