[Bug 986550] Review Request: python-xmp-toolkit - Python toolkit for working with XMP metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=986550

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Your package is noarch and stores its files in %{python_sitelib}. You have
removed the wrong header in the spec file (that one which refers to noarch
packages).

BTW, this header in general and some other parts are obsolete if you don't want
to provide your package for EPEL 5:

* the BuildRoot definition
* the initial cleaning of $RPM_BUILD_ROOT in %install
* the %clean section
* the %defattr line in %files

If you are not pointing to EPEL 5, those lines can be safely dropped. Well, you
are not forced to do so due to the guidelines, but it doesn't make sense anyway
to keep them. The functionality of the mentioned macros is default for EPEL >=
6 and all currently supported Fedora versions, and the spec file becomes better
readable. See http://fedoraproject.org/wiki/Packaging:Python#Macros for more
info.

BuildRequires: python-devel
is deprecated, you have to use python2-devel instead:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OVmVHNUnFb&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]