https://bugzilla.redhat.com/show_bug.cgi?id=905304 --- Comment #23 from Patrick Laimbock <patrick@xxxxxxxxxxxx> --- Sorry for the delay. This time I was away for a few days. Good to see things start up again. To move forward, is it safe to conclude the following: - Steve and I will co-maintain - we will use Fedora SCM, optionally using github as secondary if that's the only place were OpenDMARC developers can put their code. But github will be merged back to Fedora SCM so that Fedora SCM is the one repo to rule them all TODO: - If I understand "Depends On" correctly, we should add BZ983551 since OpenDMARC with SELinux enabled will not work without a proper SELinux policy. I don't have rights to do that. Steve, if correct, can you please add it? >From Adam's review: 0) W: service-default-enabled /etc/rc.d/init.d/opendmarc I'm not sure if OpenDMARC starts with either a socket or port and default config. Will test and provide feedback. 1) MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example: NEEDSWORK (see rpmlint item) Will check/fix that this weekend and upload new spec file. 2) MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}: NEEDSWORK - the %{?_isa} is missing (though that's a new wrinkle on me, too - there's a note attached to the guideline, read that :>) Will check/fix that this weekend and upload new spec file. 3) SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example: I'll work on that later I have not seen OpenDMARC segfault. But I did configure it before starting. Will check that this weekend and provide feedback. Anything I forgot? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3uJoPlwI5a&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review