https://bugzilla.redhat.com/show_bug.cgi?id=984605 Susi Lehtola <susi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susi.lehtola@xxxxxx Blocks| |505154 (FE-SCITECH) --- Comment #3 from Susi Lehtola <susi.lehtola@xxxxxx> --- The package MUST conform to the MPI guidelines. Also, you should add an mpich2 flavor. ** # openmpi needs ssh BuildRequires: openssh-clients This doesn't seem right. OpenMPI works just fine without ssh. ** %if 0%{?el5} BuildRequires: blas-devel Requires: blas %else BuildRequires: atlas-devel Requires: atlas %endif This is unnecessary. BuildRequires: atlas-devel is available also on EL5. Besides, the explicit require is unnecessary and thus banned by guidelines. ** You don't need to conditionalize the BuildRoot etc statements for EL5. The statements work just fine on newer distros as well. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X6kFjaZuEQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review