[Bug 878421] Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=878421

Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?(bkabrda@xxxxxxxxx |
                   |m)                          |

--- Comment #14 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
(In reply to Ken Dreyer from comment #13)
> Hi Slavek, I know you have a lot on your plate, so if you would like to hand
> the review over to Christopher or myself, please un-assign this review.

Huh, sorry, I totally forgot I'm assigned to this.

The package looks fine, just a small comment - is "0%{?rhel:1}" really
necessary? Wouldn't "0%{?rhel}" suffice? (same applies to "0%{fedora:1}")

But this is just a nit and the package is ok otherwise, so APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=olBqXMDKZq&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]