Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pdfedit - A complete pdf document editing solution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232394 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-15 06:03 EST ------- GOOD - rpmlint does not return anything either on source or on binary rpm - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum f011d456d5ccbf2b644338ba6ada2294fcca5606 pdfedit-0.2.5.tar.bz2 - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales are treated by the app itself, no presence of %{_datadir}/locale/* in the spec - not relocatable - owns all files and directories that it creates, does not take ownership of foreign files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs [*] - nothing in %doc affects runtime - app is a GUI, desktop file correctly provided and used - no .la./.pc/static files SHOULD - package builds in mock / devel & fc6/ x86_64 - program can be used (does not crash, loads a pdf ..) Bernard, please include the missing scriptlets (see comment #1) and the missing doc folder (or justify why it would not be needed) and I will approve the package. [*] please consider shipping the content of the /doc directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review