https://bugzilla.redhat.com/show_bug.cgi?id=985440 --- Comment #3 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- (In reply to Wolfgang Ulbrich from comment #2) > rpmlint.text > > Checking: cinnamon-settings-daemon-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm > cinnamon-settings-daemon-devel-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm > > cinnamon-settings-daemon-updates-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm > cinnamon-settings-daemon.x86_64: W: spelling-error %description -l en_US > keybindings -> key bindings, key-bindings, bindings > cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc > /etc/xdg/autostart/cinnamon-settings-daemon.desktop > cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc > /etc/xdg/autostart/cinnamon-fallback-mount-helper.desktop > cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc > /etc/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.conf > > Please use > %config(noreplace) > %{_sysconfdir}/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism. > conf This isn't a user configuration file and shouldn't have (noreplace) tag > > cinnamon-settings-daemon-devel.x86_64: W: no-documentation > cinnamon-settings-daemon-devel.x86_64: E: incorrect-fsf-address > /usr/include/cinnamon-settings-daemon-3.0/cinnamon-settings-daemon/cinnamon- > settings-plugin.h > > Please notice upstream about this and all the others incorrect-fsf-address > errors. I will file a Br > > cinnamon-settings-daemon-devel.x86_64: E: non-executable-script > /usr/share/cinnamon-settings-daemon-3.0/input-device-example.sh 0644L /bin/sh > > Please fix it and add a executable bit ! It's just an example file and doesn't have any function. > > cinnamon-settings-daemon-updates.x86_64: W: no-documentation > 3 packages and 0 specfiles checked; 2 errors, 6 warnings. > > Issues: > ======= > - update-desktop-database is invoked when required > Note: desktop file(s) in cinnamon-settings-daemon > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > This is a fault postive and we can ignore it, no desktop file has an mine > type. > > - Package installs a %{name}.desktop using desktop-file-install if there is > such a file. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop > > Use desktop-file-install or destop-file-validate commands to install/verify > the destop files. > > [-]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > Unversioned so-files > -------------------- > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/liba11y-keyboard.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/liba11y-settings.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libbackground.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libclipboard.so > cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcolor.so > cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcsd.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libcsdwacom.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libcursor.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libhousekeeping.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libkeyboard.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libmedia-keys.so > cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libmouse.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/liborientation.so > cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libpower.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libprint-notifications.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libscreensaver-proxy.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libsmartcard.so > cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libsound.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libxrandr.so > cinnamon-settings-daemon: > /usr/lib64/cinnamon-settings-daemon-3.0/libxsettings.so > cinnamon-settings-daemon-updates: > /usr/lib64/cinnamon-settings-daemon-3.0/libupdates.so The unversioned .so are plugins > > Let us talk in irc why they are not versioned! > > Ok, that's all for the moment, pls fix it and i will do the final review. SPEC URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-settings-daemon/2/cinnamon-settings-daemon.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-settings-daemon/2/cinnamon-settings-daemon-1.0.0-0.2.git42cc1ce.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0a8SolJeW9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review