[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=985854

--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Simone Caronni from comment #3)
> Can you explain line 21-23 of the spec file? Is mvn(org.hsqldb:hsqldb) a
> requirement for mybatis-generator-maven-plugin?
> 
> If it is, then it should be added into the "%package maven-plugin" section
> as "Requires:".
> 
> Apart from this, it seems good to go.

for this module the plugin is configured so,
and uses the dependencies listed in <dependencies>...</dependencies>
i dont know if for other projects can be the same

mybatis-generator-systests-mybatis3/pom.xml
      <plugin>
        <groupId>org.mybatis.generator</groupId>
        <artifactId>mybatis-generator-maven-plugin</artifactId>
        <version>${project.version}</version>
        <executions>
          <execution>
            <id>Generate MyBatis Artifacts</id>
            <goals>
              <goal>generate</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <sqlScript>classpath:mbg/test/common/scripts/CreateDB.sql</sqlScript>
          <jdbcDriver>org.hsqldb.jdbcDriver</jdbcDriver>
          <jdbcURL>jdbc:hsqldb:mem:aname</jdbcURL>
          <jdbcUserId>sa</jdbcUserId>
          <overwrite>true</overwrite>
        </configuration>
        <dependencies>
          <dependency>
            <groupId>org.hsqldb</groupId>
            <artifactId>hsqldb</artifactId>
            <version>${hsqldb.version}</version>
          </dependency>
          <dependency>
            <groupId>org.mybatis.generator</groupId>
            <artifactId>mybatis-generator-systests-common</artifactId>
            <version>${project.version}</version>
          </dependency>
          <dependency>
            <groupId>org.mybatis.generator</groupId>
            <artifactId>mybatis-generator-core</artifactId>
            <version>${project.version}</version>
          </dependency>
          <dependency>
            <groupId>net.sourceforge.cobertura</groupId>
            <artifactId>cobertura</artifactId>
            <version>${cobertura.version}</version>
          </dependency>
        </dependencies>
      </plugin>

Spec URL: http://gil.fedorapeople.org/mybatis-generator.spec
SRPM URL: http://gil.fedorapeople.org/mybatis-generator-1.3.2-1.fc19.src.rpm

- fix wrong file end of line encoding

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3KYhwsUy6Q&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review