https://bugzilla.redhat.com/show_bug.cgi?id=984700 Martin Bříza <mbriza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mbriza@xxxxxxxxxx | |) | --- Comment #7 from Martin Bříza <mbriza@xxxxxxxxxx> --- Spec URL: http://mbriza.fedorapeople.org/sddm/sddm.spec SRPM URL: http://mbriza.fedorapeople.org/sddm/sddm-0.1.0-2.fc19.src.rpm (In reply to Christopher Meng from comment #3) > Why do we need "BuildRequires: systemd-devel"? Isn't it "BuildRequires: > systemd"? You're right, I thought the systemd pkg-config module is in the -devel package. Fixed. (In reply to Christopher Meng from comment #5) > Something is wrong in the cmake, I see two periods. Missing BuildRequires: cmake; fixed. > 2. And one more question about your spec, I can see these lines in %files: > > %config %{_sysconfdir}/pam.d/sddm > %config %{_sysconfdir}/sddm.conf > > Can these be %config(noreplace)? Fixed. > 3. I think you should choose tarball > https://github.com/sddm/sddm/archive/0.1.0.tar.gz > > as Source0 as this software will grow bigger and bigger. Changed as per Kevin's reasoning in comment #6. Unfortunately, there isn't an option to download xz or bz2 packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KJQeFH4P17&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review