https://bugzilla.redhat.com/show_bug.cgi?id=827167 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? --- Comment #24 from Christopher Meng <cickumqt@xxxxxxxxx> --- Issues: 1. You shouldn't mark manpages as %doc 2. RPM supports systemd macro, which can make your spec more clear. http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 3. You should remove buildroot tag. 4. These lines: mv $RPM_BUILD_DIR/%{name}-%{version}/configure.ac $RPM_BUILD_DIR/%{name}-%{version}/configure-fix.ac sed -e "s|2.68|2.63|g" $RPM_BUILD_DIR/%{name}-%{version}/configure-fix.ac > $RPM_BUILD_DIR/%{name}-%{version}/configure.ac Well, why not using this: sed -e "s|2.68|2.63|g" configure.ac 5. This line: install -m 755 $RPM_BUILD_DIR/%{name}-%{version}/bumblebeed.svinit $RPM_BUILD_ROOT/%{_initddir}/bumblebeed should be install -pm 755 $RPM_BUILD_DIR/%{name}-%{version}/bumblebeed.svinit $RPM_BUILD_ROOT/%{_initddir}/bumblebeed 6. This line: install -m 644 $RPM_BUILD_DIR/%{name}-%{version}/scripts/systemd/bumblebeed.service $RPM_BUILD_ROOT/%{_unitdir}/ Why not using install -pm 644 scripts/systemd/bumblebeed.service $RPM_BUILD_ROOT/%{_unitdir}/ 7. And this: cp $RPM_BUILD_DIR/%{name}-%{version}/conf/%{name}.conf $RPM_BUILD_ROOT/%{_sysconfdir}/bumblebee/%{name}-nouveau.conf Why not cp conf/%{name}.conf $RPM_BUILD_ROOT/%{_sysconfdir}/bumblebee/%{name}-nouveau.conf As you can see there are many such lines, I don't know why you waste a lot of lines...I hope all lines with RPM_BUILD_DIR should be modified. --- Comment #25 from Christopher Meng <cickumqt@xxxxxxxxx> --- Issues: 1. You shouldn't mark manpages as %doc 2. RPM supports systemd macro, which can make your spec more clear. http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 3. You should remove buildroot tag. 4. These lines: mv $RPM_BUILD_DIR/%{name}-%{version}/configure.ac $RPM_BUILD_DIR/%{name}-%{version}/configure-fix.ac sed -e "s|2.68|2.63|g" $RPM_BUILD_DIR/%{name}-%{version}/configure-fix.ac > $RPM_BUILD_DIR/%{name}-%{version}/configure.ac Well, why not using this: sed -e "s|2.68|2.63|g" configure.ac 5. This line: install -m 755 $RPM_BUILD_DIR/%{name}-%{version}/bumblebeed.svinit $RPM_BUILD_ROOT/%{_initddir}/bumblebeed should be install -pm 755 $RPM_BUILD_DIR/%{name}-%{version}/bumblebeed.svinit $RPM_BUILD_ROOT/%{_initddir}/bumblebeed 6. This line: install -m 644 $RPM_BUILD_DIR/%{name}-%{version}/scripts/systemd/bumblebeed.service $RPM_BUILD_ROOT/%{_unitdir}/ Why not using install -pm 644 scripts/systemd/bumblebeed.service $RPM_BUILD_ROOT/%{_unitdir}/ 7. And this: cp $RPM_BUILD_DIR/%{name}-%{version}/conf/%{name}.conf $RPM_BUILD_ROOT/%{_sysconfdir}/bumblebee/%{name}-nouveau.conf Why not cp conf/%{name}.conf $RPM_BUILD_ROOT/%{_sysconfdir}/bumblebee/%{name}-nouveau.conf As you can see there are many such lines, I don't know why you waste a lot of lines...I hope all lines with RPM_BUILD_DIR should be modified. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ruz43Q5KOt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review