https://bugzilla.redhat.com/show_bug.cgi?id=984700 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mbriza@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? | |needinfo?(mbriza@xxxxxxxxxx | |) --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- Hi, 1. This morning I tried a mock build but failed with: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.e633jH + umask 022 + cd /builddir/build/BUILD + cd sddm-0.1.0 + mkdir -p i686-redhat-linux-gnu + sed -i s/-march=native// CMakeLists.txt + pushd i686-redhat-linux-gnu ~/build/BUILD/sddm-0.1.0/i686-redhat-linux-gnu ~/build/BUILD/sddm-0.1.0 + '%{cmake}' .. /var/tmp/rpm-tmp.e633jH: line 35: fg: no job control error: Bad exit status from /var/tmp/rpm-tmp.e633jH (%build) Bad exit status from /var/tmp/rpm-tmp.e633jH (%build) RPM build errors: Child return code was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps builddir/build/SPECS/sddm.spec'] Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 359, in do raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps builddir/build/SPECS/sddm.spec'] LEAVE do --> EXCEPTION RAISED Something is wrong in the cmake, I see two periods. 2. And one more question about your spec, I can see these lines in %files: %config %{_sysconfdir}/pam.d/sddm %config %{_sysconfdir}/sddm.conf Can these be %config(noreplace)? 3. I think you should choose tarball https://github.com/sddm/sddm/archive/0.1.0.tar.gz as Source0 as this software will grow bigger and bigger. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QyNf8zoyhB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review