Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: thunar-volman - Automatic management of removable drives and media for the Thunar file manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229930 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx Flag| |fedora-review? ------- Additional Comments From kevin@xxxxxxxxx 2007-03-15 00:44 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 910de35c398f70b66b38803bdfdd26f1 thunar-volman-0.1.2.tar.bz2 910de35c398f70b66b38803bdfdd26f1 thunar-volman-0.1.2.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Is the "Requires: Thunar >= %{thunarver}" needed? rpm picks up on the requires of "libthunar-vfs-1.so.2" which pulls in Thunar. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review