https://bugzilla.redhat.com/show_bug.cgi?id=985129 --- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> --- > Name: text2nato > Summary: text2nato is an utility to convert text into nato phonetic Package installer tools typically display the Name and the Summary, so repeating the name at the beginning of the summary is a waste of space. https://fedoraproject.org/wiki/Examples_of_good_package_summaries Summary: Convert text into nato phonetic alphabet > BuildRequires: perl Not true yet. You only install a prebuilt file. > BuildRoot: %{_tmppath}/ https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > License: GPLv2+ https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification and https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > %files > /usr/bin/text2nato > mkdir -p %{buildroot}%{_bindir}/ > cp -p text2nato %{buildroot}%{_bindir}/ If you use macros, use them consistently. Choose between /usr/bin and %{_bindir} but not mix both forms. https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > %install > rm -rf %{buildroot} https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > %changelog Do practise maintaining this %changelog section. Even during Fedora Package Review, there ought to be at least a first changelog entry. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vpq4FqlcEn&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review