https://bugzilla.redhat.com/show_bug.cgi?id=984560 --- Comment #3 from Yajo <yajo.sk8@xxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > 1. Can you build your spec under Fedora instead of OBS? Of course. I built it there before uploading. > 2. Have you read the guidelines? > > [...] Yes, I did. However sorry for my newbieness. All you said is fixed now. > And a friendly note, please do not use OBS to build RPM for Fedora. I found it very practical. Is there any recommended similar service? This time I uploaded everything to the closed-source Google Drive. I hope people like it. (In reply to Antonio Trande from comment #2) > Hi Yajo. > > Please, add a briefly description of package in the review summary, too. > See this example: > http://fedoraproject.org/wiki/File:PackageReviewProcess_review.png > > It would be better add a comment about included patch. > See > http://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > > You need a validate task of the '.desktop' file. > http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files All done, thanks. New SPEC: https://docs.google.com/file/d/0B6L4jqW88ytdamlWdS0zZHR6SjA/edit?usp=sharing New SRPM: https://docs.google.com/file/d/0B6L4jqW88ytdNzJ0dEQ4b0NDUlk/edit?usp=sharing -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iC66hIqmAy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review
