https://bugzilla.redhat.com/show_bug.cgi?id=985065 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Hi, 1. I think your desktop file is incorrect. [Desktop Entry] Exec='/usr/games/peg-solitaire' The path is wrong. Icon=/usr/share/pixmaps/peg-solitaire.xpm This kind of way to define a icon is not recommended now, is it possible to change to "Icon=peg-solitaire"?(I'm sorry I haven't tried it) MimeType= Well this is just a game and no new MIME types are being introduced, so you don't need to add %post{un} scriptlet to update the database. 2. In your spec I can find find_lang script, but you've commented out them, and there are language files in the tarball in fact. Please fix. 3. I can see "${RPM_BUILD_ROOT}" in your spec. However as we can see from the guideline http://fedoraproject.org/wiki/Packaging:Guidelines#UsingBuildRootOptFlags You can use $RPM_BUILD_ROOT or %{buildroot} to define the buildroot, but now you use a special style "${RPM_BUILD_ROOT}"... So, if you want to use macro style, change it to %{buildroot}; Otherwise please change it to variable style. Mix using 2 style is WRONG, and you mix them in one new style is WRONG again. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=crNcj07Pbr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review