[Bug 983774] Review Request: xmp-plugin-audacious - A multi-format module playback plugin for Audacious

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=983774

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |957918
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> Provides: audacious-plugin-xmp = %{version}-%{release}
> Obsoletes: audacious-plugin-xmp <= 3.5.0-3

The "Obsoletes" tag is not high enough. It must be

  Obsoletes: audacious-plugin-xmp < 3.5.0-4
or
  Obsoletes: audacious-plugin-xmp <= 3.5.0-3.fc20  (with hardcoded .fc20!)

because the last build of that package has been a subpackage of
xmp-3.5.0-3.fc20 (also for .fc19 and .fc18).


The "Provides" shall be kept to meet the requirements of the "Addon Packages
(General) Naming Guidelines":
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29

Those guidelines aren't too precise, however, since for Audacious the %{parent}
name may be "audacious" as well as "audacious-plugins". There's no requirement
for a separate plugin to use the audacious-plugins- prefix.

It would be an opportunity to s/plugin/plugins/ in the "Provides", however.


> License: GPLv2+

Confirmed.


> %description
> ...
> and Amiga file packers including gzip, bzip2, SQSH, Powerpack, etc.

"PowerPacker" is its name.
( http://rewiki.regengedanken.de/wiki/Amiga_PowerPacker )


> Summary: A multi-format module playback plugin for Audacious using libxmp

In package installers, which display these summaries, it looks better
(and more concise) when omitting these leading articles:

  Summary: Multi-format module playback plugin for Audacious using libxmp

https://fedoraproject.org/wiki/Examples_of_good_package_summaries



Any fixes can be applied in pkg git.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9gCpkEB61h&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]