[Bug 984560] Review Request: Enki

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=984560

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cickumqt@xxxxxxxxx

--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Hey, 

1. Can you build your spec under Fedora instead of OBS?



2. Have you read the guidelines?

- You shouldn't use define to create a custom macro,  please use global;

- Your BuildRequires are wrong, please fix. Like setuptools, you shouldn't use
development package. And python version in Fedora doesnt have 2.6.6, please,
use Fedora to test.

- You have desktop files installed, but you don't validate it. Please use
desktop-file-utils to validate. 

- You have icons installed, please update the cache. 

- Your source0 tag is missing,  however source is ok. But its syntax is wrong
again. 

For more details of fixing,  please read our guidelines.

And a friendly note, please do not use OBS to build RPM for Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DnGJTr9MNG&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]