https://bugzilla.redhat.com/show_bug.cgi?id=975041 --- Comment #3 from Vitezslav Crhonek <vcrhonek@xxxxxxxxxx> --- (In reply to michal.simon from comment #2) Thanks for taking the review! > > 3. In spec file you only mention EPL licence and the ltmain.sh uses GPL this > has to be fixed > (https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#Multiple_Licensing_Scenarios). ltmain.sh is generated file and states: # As a special exception to the GNU General Public License, # if you distribute this file as part of a program or library that # is built using GNU Libtool, you may include this file under the # same distribution terms that you use for the rest of that program. So I think that adding GPL is not necessary? > > > 4. In the devel package you should have: > %{name}%{?_isa} = %{version}-%{release} > rather than: > %{name} = %{version}-%{release} Fixed. > > 5. Instead of: > %{_libdir}/libsfcUtil.so.0.0.0 > %{_libdir}/libsfcUtil.so.0 > you could do just: > %{_libdir}/libsfcUtil.so.* > but that's optional Changed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bNDG9NDk8r&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review