[Bug 983784] Review Request: myrtle - A simple programmable spreadsheet designed for learning statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=983784

--- Comment #10 from Christopher Meng <cickumqt@xxxxxxxxx> ---
No big problems now.

But don't put

desktop-file-validate
%{buildroot}/%{_datadir}/applications/mockturtlesolutions-myrtle.desktop

under %posttrans section, RPM cannot identify when it should be executed.

Please move it under %check section.

Since check section is not mentioned in your spec, you should add a %check
section, and then write down this. Like this:

[snip..]

desktop-file-install --dir=%{buildroot}%{_datadir}/applications
mockturtlesolutions-myrtle.desktop
install myrtle $RPM_BUILD_ROOT%{_bindir}
#Copy over desktop icons...
cp -R icons/* $RPM_BUILD_ROOT/usr/share/icons 

%check
desktop-file-validate
%{buildroot}/%{_datadir}/applications/mockturtlesolutions-myrtle.desktop

%post
#Update the icon cache.
/bin/touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
[snip again...]

Remember putting same things in different locations can cause problem, and you
knew this when you put the %description after the %prep days ago. So please
sort them out in order.

I think you can search a possible sponsor now.

Please read:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=64RvnfNed0&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]