https://bugzilla.redhat.com/show_bug.cgi?id=983784 --- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> --- Yeah, still many problems. But anyway it's better now. Issues: 1. Please remove "BuildRoot" tag, since RPM 4.4, this is not needed. 2. Your "Release" tag is incorrect. Please read this page to understand: https://fedoraproject.org/wiki/Packaging:DistTag 3. Remove this line in %install section:"rm -rf $RPM_BUILD_ROOT" 4. Remove whole %clean section as modern RPM can handle this. 5. Macros are not perfect. In Fedora, /usr/share is %{_datadir}, please don't use %{_prefix}/share. 6. I found that you created a Directory /usr/local/bin, why? http://fedoraproject.org/wiki/Packaging:Guidelines#No_Files_or_Directories_under_.2Fsrv.2C_.2Fopt.2C_or_.2Fusr.2Flocal 7. Desktop file should be installed by desktop-file-utils, you included it in BR(BuildRequires), but you didn't use it to install such file, that's bad. Fix: desktop-file-install \ --dir=%{buildroot}%{_datadir}/applications \ mockturtlesolutions-myrtle.desktop 8. Update icon cache script is wrong. Please refer to: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 9. %changelog section is missing, please include it. This is a MUST. You can use rpmdev tools to made a change log, but I think know you hate need to know the basics. Please read this: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 10. Your "Summary" filed has a dot at the end of itself, please remove it. This is a MUST. 11. In %files section, we can see junks of icon locations, and because these icons just have one same name, you can replace these 12 lines with %{_datadir}/icons/hicolor/*x*/apps/%{name}.png Since you've pulled in java dependencies, %{_datadir}/icons can be replaced by %{_iconsdir}, however if you cannot build on Koji, please undo this. Suggestions: 1. I think you didn't follow RPM rules very well in the past, but don't be worried, we can do better! 2. RPM in Fedora have many macros, although comparing with OpenSUSE, we only have little, you can still work with macros very well. If you don't know what macro equals to what, just type in the terminal: rpm -E macroname which macroname should be replaced by something's like:"%{_datadir}", "%configure","%{_javadir}" and so on. If you want to know some seldom used macros, just type rpm -E, then press Tab to show all possibilities. 3. Please read our guideline carefully: http://fedoraproject.org/wiki/Packaging:Guidelines You can find that all your mistakes can be found in this page. You still need to find a sponsor, I don't know java, so I cannot help you. But please fix packaging issues I mentioned before you do that. I hope the sponsor won't be annoyed by these packaging issues, so he can just concentrate on this package's code. And please learn how to write changelog, because you should bump the release version and write in the change log to introduce what you've done to the spec. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hFPPon2UWy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review