Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ettercap - Network traffic sniffer/analyser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746 ------- Additional Comments From opensource@xxxxxxxxx 2007-03-14 15:21 EST ------- (In reply to comment #33) > [wolfy@wolfy64 result]$ rpm -qp --provides ettercap-gtk-0.7.3-5.fc7.x86_64.rpm > ettercap > ettercap-gtk = 0.7.3-5.fc7 > I am almost sure that the unversioned provides in ettercap-gtk should be > modified to ettercap-name-version I guess you mean it should be (I hope this is the correct syntax): Provides: ettercap = %{version}-%{release} Also the -common package should have: Requires: ettercap-common = %{version}-%{release} And from the description of the ettercap package: | This package contains the NCURSES version. Better change it to "This package supports the daemon mode and contains the text and ncurses user interface." (In reply to comment #45) > [2] - adding libtool-ltdl-devel as BR (instead of libtool) allows bulding of the > plugins. I have verified and there are no problems, they just need to be > included in a package. I suggest a 4th package (ettercap-plugins) for that (this > is a nice to have, technically is not a blocker, just a possible, easy to add > but missing feature) Please do this :-) > MUSTFIX: the -common packages creates symlinks which are not valid unless the > text-only rpm is installed. This is not nice. I think that a bit of magic is > needed here. One fix could be to create the symlinks in %post in the text and > gtk rpms, and only if they do not exist already. Using alternatives seems not to be that complicated, too. Install ettercap in the ettercap package to %{_bindir}/ettercap.ettercap and use this: %post %{_sbindir}/alternatives --install %{_bindir}/ettercap ettercap {_bindir}/ettercap.ettercap 30 %post gtk %{_sbindir}/alternatives --install %{_bindir}/ettercap ettercap {_bindir}/ettercap-gtk 30 %preun if [ "$1" = 0 ]; then {_sbindir}/alternatives --remove ettercap %{_bindir}/ettercap.ettercap fi %preun gtk if [ "$1" = 0 ]; then {_sbindir}/alternatives --remove ettercap %{_bindir}/ettercap-gtk fi The ettercap and -gtk package also need: Requires(post) %{_sbindir}/alternatives Requires(preun) %{_sbindir}/alternatives see man alternatives for help. > - you can dump "Provides ettercap" in the -gtk package. I have just tested after It still should be there, because the -common package should require ettercap-version-release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review