[Bug 977208] Review Request: Phalcon - A web framework implemented as a C extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=977208

--- Comment #17 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> ---
(In reply to Björn Esser from comment #11)
> Created attachment 767313 [details]
> use install-script to get some needed parameters for build
> 
> This is needed in addition to the spec-file improvements.

Hello,

IMHO, this is totally unnecessary and overcomplicated. That binary decides if
this is a 64bit or 32bit system; in an overcomplicated way, if you ask me.

I'd rather implement this on the SPEC file and not rely on some C script to do
it; it's redundant. What do you think?

Here's the code for gccarch.c; which is obvious.

## gccarch.c 
#include <stdio.h>

// Check windows
#if _WIN32 || _WIN64
#if _WIN64
#define ENVIRONMENT64 
#else
#define ENVIRONMENT32
#endif
#endif

// Check GCC
#if __GNUC__
#if __x86_64__ || __ppc64__
#define ENVIRONMENT64
#else
#define ENVIRONMENT32
#endif
#endif

int main(){
#ifndef ENVIRONMENT32
printf("%d", 1);
#else
printf("%d", 0);
#endif
}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iaLg2Utz0x&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]