Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: maven-wagon-1.0-0.a5.3jpp - Maven Wagon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227085 tbento@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- |fedora-review+ ------- Additional Comments From tbento@xxxxxxxxxx 2007-03-14 14:21 EST ------- (In reply to comment #4) > (In reply to comment #3) > > ... > > X verify source and patches (md5sum matches upstream, know what the patches do) > > - if upstream doesn't release source drops, put *clear* instructions on > > how to generate the the source drop; ie. > > # svn export blah/tag blah > > # tar cjf blah-version-src.tar.bz2 blah > > > > The md5sum do not match. When I do a diff, I get the following: > > diff -r > > > wagon-1.0-alpha-5/wagon-provider-api/src/main/java/org/apache/maven/wagon/util/IoUtils.java > > > ../upstream/wagon-1.0-alpha-5/wagon-provider-api/src/main/java/org/apache/maven/wagon/util/IoUtils.java > > 80c80 > > < * @version CVS $Revision: 290775 $ $Date: 2005-09-21 20:25:08 +0200 (Wed, 21 > > Sep 2005) $ > > --- > > > * @version CVS $Revision: 290775 $ $Date: 2005-09-21 14:25:08 -0400 (Wed, 21 > > Sep 2005) $ > > > > I think this is okay. > Hmm, interesting, I just did another source export so this should not be an > issue anymore. Looks good. > > X skim the summary and description for typos, etc. > > Summary should be "Tools to manage artifacts and deployment". Looks good. > > - Should gcj support be added? > since this package will be updated at a later date to support a maven2 build, I > would suggest adding the gcj support aot bits at that time. Sure. Sounds good. I've built it on mock with no problems. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review