[Bug 983608] Review Request: gpaw - A density-functional theory code based on the PAW method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=983608

--- Comment #2 from Susi Lehtola <susi.lehtola@xxxxxx> ---
(In reply to Christopher Meng from comment #1)
> Hi,
> 
> Please remove python_sitearch define, BuildRoot tag, rm -rf %{buildroot} in
> %install section, whole %clean section and %defattr(-,root,root,-) from your
> spec.

Although these are defaulted on current versions of Fedora, having them doesn't
hurt and is in fact necessary to be able to build on EPEL.

> As SRPM needs all BRs to build main and sub pkgs, no matter how many
> subpackages are existed, please move all BuildRequires in subpackages, like:

Non sequitur. The SRPM will get all the BRs from the subpackages. The separate
BRs for the subpackages are because the BRs are only for those subpackages. If
there is yet another MPI runtime, it will get its own subpackage and own
buildrequires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WkwOPkc4DU&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]