[Bug 979656] Review Request: perl-Set-Array - Arrays as objects with lots of handy methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979656

--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f20

- rpmlint output on rpms gave
perl-Set-Array.noarch: W: spelling-error %description -l en_US lang -> Lang,
lag, slang
perl-Set-Array.noarch: W: file-not-utf8
/usr/share/doc/perl-Set-Array-0.29/Changelog.ini
perl-Set-Array.noarch: W: file-not-utf8
/usr/share/doc/perl-Set-Array-0.29/Changes
perl-Set-Array.src: W: spelling-error %description -l en_US lang -> Lang, lag,
slang
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> Fix the rpmlint warnings

+ Source verified with upstream as (sha256sum)
srpm tarball     :
4e1e35ae5480310032754f5410eaba9381c6c84c992d6f6ec59aad2b84c38c3d
upstream tarball :
4e1e35ae5480310032754f5410eaba9381c6c84c992d6f6ec59aad2b84c38c3d

+ License "Artistic 2.0" is valid.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.

+ Package: perl-Set-Array-0.29-1.fc20.noarch
Provides: perl(Set::Array) = 0.29 perl-Set-Array = 0.29-1.fc20
Requires: perl(Carp) perl(Try::Tiny) perl(Want) perl(attributes) perl(strict)
perl(subs)

suggestions:
1) Remove Changelog.ini as it looks same as Changes file.

2) Fix rpmlint file-not-utf8 by adding following to %prep
iconv -f iso8859-1 -t utf-8 Changes > Changes.conv && mv -f Changes.conv
Changes

3) Remove commented lines if you are not planning to use them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k9AznzlYwa&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]