https://bugzilla.redhat.com/show_bug.cgi?id=977208 --- Comment #15 from Roman Mohr <roman@xxxxxxxxxxxx> --- (In reply to Björn Esser from comment #9) > (In reply to Roman Mohr from comment #7) > > Nice review, Roman. But here are some things / questions I stumbled upon > just looking on spec-file... Thx for your detailed comments Björn. > > > [x]: %build honors applicable compiler flags or justifies otherwise. > > Should be FAIL, because spec-file appends flags to system-flags: > CFLAGS="%{optflags} -O2 -fno-delete-null-pointer-checks -finline-functions > -fomit-frame-pointer" Why? What's the use/benefit of that? Any > explanation? You are right deeper inspection is necessary. > > > [-]: %check is present and all tests pass. > > > > ---> There are a lot of unit tests but they are only applicable if > > compiled from the development branch. No blocker. > > Is there any way to run the checks during build, e.g. initializing a fake > git repo in source-tree or some other hack? See the patch above :) . One Question remains: Is there a standard way (or a way at all) to run unit-tests which depend on a database? Is it possible to just install and start a server in koji? I have to check/try that. > > > Rpmlint (installed packages) > > ---------------------------- > > # rpmlint php-phalcon > > php-phalcon.x86_64: W: private-shared-object-provides > > /usr/lib64/php/modules/phalcon.so phalcon.so()(64bit) > > php-phalcon.x86_64: W: no-documentation > > 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > > # echo 'rpmlint-done:' > > > > > > Provides > > -------- > > php-phalcon: > > config(php-phalcon) > > phalcon.so()(64bit) > > php-phalcon > > php-phalcon(x86-64) > > You should filter the private so provides. See instructions here: > https://fedoraproject.org/wiki/Packaging: > AutoProvidesAndRequiresFiltering#Filtering_provides_and_requires_after_scanni > ng Thx for the link. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bEYhUXaJAu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review